From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: backlight: Add max25014 support Date: Sun, 12 Apr 2026 13:25:20 +1000 Message-ID: In-Reply-To: <20260407-max25014-v8-1-14eac7ed673a@gocontroll.com> References: <20260407-max25014-v8-0-14eac7ed673a@gocontroll.com> <20260407-max25014-v8-1-14eac7ed673a@gocontroll.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review This patch adds the YAML binding and MAINTAINERS entry. It has Rob Herring'= s Reviewed-by. **Minor observations:** 1. The `maxim,strings` description says "A 4-bit bitfield" but the represen= tation is a 4-element array of `uint32`, not a bitfield. The description is= slightly misleading =E2=80=94 it's an array of 4 enable/disable flags, not= a bitfield. Consider: "An array of 4 values (0 or 1) describing which LED = strings to enable." 2. The binding declares `interrupts` and `pwms` properties but the driver d= oesn't implement either of these features. This is acceptable for forward-c= ompatibility as documented in the cover letter, but it's worth noting. 3. The `default-brightness` property lacks a `$ref` to a type schema. While= it will likely be inferred, adding `$ref: /schemas/types.yaml#/definitions= /uint32` would be consistent with `maxim,iset`. **No blocking issues.** The binding is clean and the Rob R-b carries weight. --- --- Generated by Claude Code Patch Reviewer