Claude review: arm64: dts: freescale: moduline-display-av123z7m-n17: add backlight

Claude Code Review Bot
2026-04-12T03:25:21Z

Patch Review

This patch replaces a placeholder comment `/* max25014 @ 0x6f */` with the actual device node.

```dts
- /* max25014 @ 0x6f */
+ backlight: backlight@6f {
```

Clean replacement of the placeholder. The node properties are consistent with patch 3 except `maxim,strings = <1 1 1 1>` (all 4 strings enabled vs. 3 in patch 3), which makes sense for a different display panel.

**No issues with this patch.**

---

### Summary of required/recommended changes

| Priority | Issue | Patch |
|----------|-------|-------|
| Should fix | Missing `#include <linux/regulator/consumer.h>` | 2/4 |
| Should fix | Replace `of_match_ptr()` with direct reference | 2/4 |
| Should fix | Fix indentation of for-loop closing brace in `max25014_parse_dt` | 2/4 |
| Should fix | Disable hardware (clear ISET_ENA) in `max25014_remove` | 2/4 |
| Nit | Use `u32`/`u8` instead of `uint32_t`/`uint8_t` | 2/4 |
| Nit | Replace binary literals with hex | 2/4 |
| Nit | Simplify `!((x) == y)` to `(x) != y` | 2/4 |
| Nit | Use `BIT(i)` instead of `1 << i` in check_errors | 2/4 |
| Nit | Remove unused `MIN_BRIGHTNESS` and `TON_MIN` defines | 2/4 |
| Nit | Use a separate variable for initial power state in probe | 2/4 |