Claude review: backlight: add new max25014 backlight driver

Claude Code Review Bot
2026-04-12T03:25:20Z

Overall Series Review

Subject: backlight: add new max25014 backlight driver
Author: Maud Spierings via B4 Relay
<devnull+maudspierings.gocontroll.com@kernel.org>
Patches: 5
Reviewed: 2026-04-12T13:25:20.719247

---

This is a well-structured 4-patch series adding a new driver for the Maxim MAX25014 automotive backlight controller. The series is at v8 and has already received Reviewed-by tags from Rob Herring (binding) and Daniel Thompson (driver). The overall shape is good: binding first, then driver, then DTS consumers. However, there are several issues ranging from minor style nits to a few substantive problems that should be addressed.

**Key concerns:**
1. Missing `#include <linux/regulator/consumer.h>` in the driver
2. `of_match_ptr()` usage is discouraged for new drivers
3. Indentation bug in `max25014_parse_dt`
4. The `remove` function doesn't fully shut down the hardware
5. Kernel type conventions (`u32`/`u8` preferred over `uint32_t`/`uint8_t`)
6. Binary literals are unusual in kernel code