From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dma-fence: correct kernel-doc function parameter @flags Date: Sun, 12 Apr 2026 14:05:33 +1000 Message-ID: In-Reply-To: <20260407043649.2015894-1-rdunlap@infradead.org> References: <20260407043649.2015894-1-rdunlap@infradead.org> <20260407043649.2015894-1-rdunlap@infradead.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Status: Correct but already applied** The patch makes two changes: 1. **Missing colon in kernel-doc `@flags` tag:** ```diff - * @flags the CPU flags to restore + * @flags: the CPU flags to restore ``` This is a valid fix. Kernel-doc requires the `@param:` format with a colon;= without it, `make htmldocs` emits the warning cited in the commit message. 2. **Grammar fix =E2=80=94 "it's" =E2=86=92 "its":** ```diff - * Unlock the fence, allowing it to change it's state to signaled again. + * Unlock the fence, allowing it to change its state to signaled again. ``` Correct =E2=80=94 "its" (possessive) is right here, not "it's" (contraction= of "it is"). **Observations:** - The `Fixes:` tag references `3e5067931b5d ("dma-buf: abstract fence locki= ng v2")` which is the commit that introduced the doc comment with the typos= . Appropriate. - The patch is against `linux-next-20260406` (visible from the `---`/`+++` = paths). The drm-next tree already contains both fixes at lines 411 and 413,= so this patch has already been merged or an equivalent fix was applied ind= ependently. - The diff context, line numbers, and surrounding code all check out. - Appropriate Cc list (Christian K=C3=B6nig as dma-buf/dma-fence maintainer= , Sumit Semwal, linux-media). **Verdict:** The patch is correct in both substance and form, but is a no-o= p against current drm-next since the fix is already present. If reviewing a= gainst the original base where the typos still exist, this is a clean **Rev= iewed-by**-worthy patch. --- Generated by Claude Code Patch Reviewer