From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: uapi: Use SPDX in DRM core uAPI headers Date: Sun, 12 Apr 2026 13:38:53 +1000 Message-ID: In-Reply-To: <20260407104951.1781047-1-laurent.pinchart+renesas@ideasonboard.com> References: <20260407104951.1781047-1-laurent.pinchart+renesas@ideasonboard.com> <20260407104951.1781047-1-laurent.pinchart+renesas@ideasonboard.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Documentation change (`Documentation/gpu/drm-uapi.rst`):** The added paragraph is well-placed, directly after the discussion of uAPI r= eview requirements and before the render nodes section: ``` +The DRM subsystem has however no concern with independent closed-source +userspace implementations. To officialize that position, the DRM uAPI head= ers +are covered by the MIT license. ``` Minor nit: "officialize" is not a standard English word =E2=80=94 "formaliz= e" would be more conventional. That said, the meaning is perfectly clear, a= nd this has already been reviewed by multiple maintainers including Simona = who participated in the original discussion, so this is not worth blocking = on. **Header changes (`drm.h`, `drm_fourcc.h`, `drm_mode.h`, `drm_sarea.h`):** All four headers follow the same clean pattern: 1. Add `/* SPDX-License-Identifier: MIT */` as the very first line 2. Remove the verbose MIT license text 3. Preserve copyright notices and author attributions The changes are mechanically correct. The SPDX tag is placed on line 1 as r= equired by kernel convention, copyright lines are retained, and no function= al code is touched. The slight variations in the removed license text (e.g.= , `drm.h` names "VA LINUX SYSTEMS", `drm_sarea.h` names "TUNGSTEN GRAPHICS"= , `drm_mode.h` uses "AUTHORS OR COPYRIGHT HOLDERS") are all correctly ident= ified as MIT license variants and appropriately replaced by the single `MIT= ` SPDX identifier. One observation: `drm.h` has a slightly unusual structure after the patch = =E2=80=94 it ends up with two separate comment blocks (one for the header d= escription/author and one for the copyright notices). This is a pre-existin= g structure and the patch handles it correctly by inserting the SPDX tag be= fore the first block and removing the license text from the second. **No concerns.** The patch is clean, well-reviewed, and correct. Recommend = merging. --- Generated by Claude Code Patch Reviewer