From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/radeon: replace nested min calls with min3 Date: Sun, 12 Apr 2026 13:20:25 +1000 Message-ID: In-Reply-To: <20260407181407.1052586-2-thorsten.blum@linux.dev> References: <20260407181407.1052586-2-thorsten.blum@linux.dev> <20260407181407.1052586-2-thorsten.blum@linux.dev> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Status:** Reviewed-by worthy The patch modifies two functions that are structurally identical across two files: - `dce8_available_bandwidth()` in `drivers/gpu/drm/radeon/cik.c` - `dce6_available_bandwidth()` in `drivers/gpu/drm/radeon/si.c` In both cases, the change is: ```c - return min(dram_bandwidth, min(data_return_bandwidth, dmif_req_bandwidth)); + return min3(dram_bandwidth, data_return_bandwidth, dmif_req_bandwidth); ``` **Correctness:** The kernel's `min3()` macro (from `linux/minmax.h`) is equivalent to `min(a, min(b, c))`, so this is a no-op in terms of behavior. All three variables are `u32`, so there are no type-promotion concerns. **Commit message:** Accurate and concise. Correctly names both affected functions. **No issues found.** This is a clean readability improvement with no risk. --- Generated by Claude Code Patch Reviewer