From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/vram: remove DRM_VRAM_MM_FILE_OPERATIONS from docs Date: Sun, 12 Apr 2026 12:11:01 +1000 Message-ID: In-Reply-To: <20260408-drm_gem_vram_helper_docs-v1-1-4d667a768f75@igalia.com> References: <20260408-drm_gem_vram_helper_docs-v1-1-4d667a768f75@igalia.com> <20260408-drm_gem_vram_helper_docs-v1-1-4d667a768f75@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Status: Looks good** The patch makes three improvements in the kernel-doc comment block: 1. **Prose text update** (line 52 context): Changes `&DRM_VRAM_MM_FILE_OPER= ATIONS to initialize` to `&DEFINE_DRM_GEM_FOPS to define`. The verb change = from "initialize" to "define" is accurate =E2=80=94 `DEFINE_DRM_GEM_FOPS` *= defines* a `struct file_operations` (it's a declaration macro), whereas the= old `DRM_VRAM_MM_FILE_OPERATIONS` was a field-initializer macro used *insi= de* a struct definition. Also fixes a double-space typo (`and &DRM_VRAM_MM= _FILE_OPERATIONS` =E2=86=92 `and &DEFINE_DRM_GEM_FOPS`). 2. **Code example update**: Replaces the manual struct definition: ```c struct file_operations fops =3D{ .owner =3D THIS_MODULE, DRM_VRAM_MM_FILE_OPERATION }; ``` with the modern one-liner: ```c DEFINE_DRM_GEM_FOPS(fops); ``` This matches how real drivers use the macro (confirmed by the definition= in `include/drm/drm_gem.h:492`). 3. **Bonus fix**: The old code example had a pre-existing typo =E2=80=94 `D= RM_VRAM_MM_FILE_OPERATION` (missing trailing `S`). This is now moot since t= he entire block is replaced. **No issues found.** The commit message is clear, references the originatin= g commit, and the change is minimal and well-scoped. Reviewed-by tag recommendation: This patch is ready to apply as-is. --- Generated by Claude Code Patch Reviewer