From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/exynos/gem: Fix printk specifier for gem_object.size and dma_addr Date: Sun, 12 Apr 2026 13:01:45 +1000 Message-ID: In-Reply-To: <20260408064936.1342321-1-wenst@chromium.org> References: <20260408064936.1342321-1-wenst@chromium.org> <20260408064936.1342321-1-wenst@chromium.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Verdict: Looks good.** Two changes are made in two call sites (`exynos_drm_alloc_buf` and `exynos_= drm_free_buf`): 1. **`size` format: `%lx` =E2=86=92 `%zx`** =E2=80=94 Correct. `drm_gem_obj= ect.size` is `size_t` (confirmed in `include/drm/drm_gem.h:341`), and `%zx`= is the proper format specifier for `size_t`. This eliminates the warning o= n architectures where `size_t !=3D unsigned long` (e.g., 32-bit ARM). 2. **`dma_addr` format: `%lx` with cast =E2=86=92 `%pad` by reference** =E2= =80=94 Correct and an improvement. Per `Documentation/core-api/printk-forma= ts.rst:257`, `%pad` is the canonical kernel format for `dma_addr_t`, and it= is passed by reference (hence the `&exynos_gem->dma_addr`). This removes t= he lossy `(unsigned long)` cast that would truncate the address on 32-bit p= latforms with 64-bit DMA addresses (e.g., `CONFIG_ARCH_DMA_ADDR_T_64BIT`). ```diff - DRM_DEV_DEBUG_KMS(drm_dev_dma_dev(dev), "dma_addr(0x%lx), size(0x%lx)\n", - (unsigned long)exynos_gem->dma_addr, exynos_gem->base.size); + DRM_DEV_DEBUG_KMS(drm_dev_dma_dev(dev), "dma_addr(%pad), size(0x%zx)\n", + &exynos_gem->dma_addr, exynos_gem->base.size); ``` Minor note: `%pad` already prints the `0x` prefix (the kernel documentation= shows `0x01234567`), so the output format changes slightly from `dma_addr(= 0x...)` to `dma_addr(0x...)` =E2=80=94 this is fine and arguably more corre= ct since it avoids a double `0x` if one was ever added. The alignment fix (extra space to align under `drm_dev_dma_dev`) is also a = nice touch. **Reviewed-by worthy.** The commit message is clear, references the Fixes t= ag and the build robot report, and the code change is mechanical and correc= t. --- Generated by Claude Code Patch Reviewer