From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/exynos/fimd: fix register offset type in fimd_trigger() Date: Sun, 12 Apr 2026 13:00:10 +1000 Message-ID: In-Reply-To: <20260408065055.1353444-1-wenst@chromium.org> References: <20260408065055.1353444-1-wenst@chromium.org> <20260408065055.1353444-1-wenst@chromium.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Status: Clean, correct fix.** The `ctx->regs` field is declared as `void __iomem *regs` (line 182 of `exynos_drm_fimd.c`). When `fimd_trigger()` computes a derived pointer from it: ```c - void *timing_base = ctx->regs + driver_data->timing_base; + void __iomem *timing_base = ctx->regs + driver_data->timing_base; ``` the old code drops the `__iomem` address space annotation, which causes sparse to rightfully complain when `timing_base` is later passed to `readl()` and `writel()` (lines 1005 and 1007), which expect `__iomem`-qualified pointers. Adding `__iomem` to the local variable type makes the types consistent throughout the function. This is a no-op change at the binary level (sparse annotations have no runtime effect) but improves static analysis coverage. The `Fixes:` tag correctly points to commit `3854fab24e89` which introduced the `fimd_trigger()` function with the original type mismatch. Reviewed-by worthy as-is. --- Generated by Claude Code Patch Reviewer