From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panthor: Fix kernel-doc in panthor_sched.c so it's visible Date: Sun, 12 Apr 2026 12:47:45 +1000 Message-ID: In-Reply-To: <20260408091242.799074-1-steven.price@arm.com> References: <20260408091242.799074-1-steven.price@arm.com> <20260408091242.799074-1-steven.price@arm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Typo bug -- `@synwait.sync64` should be `@syncwait.sync64`:** The patch introduces a typo in one of the very fixes it's making: ``` - /** @sync64: True if this is a 64-bit sync object. */ + /** @synwait.sync64: True if this is a 64-bit sync object. */ ``` This should be `@syncwait.sync64` (missing the 'c'). All other members of the same anonymous struct correctly use `@syncwait.*` (e.g. `@syncwait.gpu_va`, `@syncwait.ref`, `@syncwait.gt`, `@syncwait.obj`, `@syncwait.offset`, `@syncwait.kmap`). This typo means `sync64` would still not be properly visible in kernel-doc output, which defeats the purpose of the patch for this particular field. **Fix for stale `@bo` tag name is good, but leaves a dangling cross-reference:** The patch correctly renames the doc tag from `@bo` to `@syncwait.obj` to match the actual field name `obj`: ``` - /** @bo: Buffer object holding the synchronization object. */ + /** @syncwait.obj: Buffer object holding the synchronization object. */ ``` However, the description of the next member still references `@bo`: ``` + /** @syncwait.offset: Offset of the synchronization object inside @bo. */ ``` Now that the tag has been corrected to `@syncwait.obj`, this `@bo` cross-reference is dangling. It should be updated to `@syncwait.obj` (or simply `@obj`) for consistency. This is a minor nit but worth fixing while you're in this code. **Rest of the changes look correct.** The mechanical addition of parent struct prefixes (`@groups.`, `@pm.`, `@reset.`, `@iface.`, `@fence_ctx.`, `@profiling.`, `@fdinfo.`, `@call_info.`, `@ringbuf.`) all match the actual anonymous struct field names in the source tree. The `Fixes:` tag referencing the original commit that introduced the scheduler is appropriate. --- Generated by Claude Code Patch Reviewer