Claude review: drm/i915/gem: Don't use VMA from wrong VM in EXECBUF

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

**Correctness: Good.** The logic change is sound:

```c
-		if (likely(vma && vma->vm == vm))
+		if (likely(vma && vma->vm == vm)) {
 			vma = i915_vma_tryget(vma);
+		} else {
+			WARN_ON_ONCE(vma && vma->vm != vm);
+			vma = NULL;
+		}
```

The `else` branch is entered when `!(vma && vma->vm == vm)`, which covers two cases:
1. `vma == NULL` — no entry in radix tree (benign, `WARN_ON_ONCE` condition is false)
2. `vma != NULL && vma->vm != vm` — wrong VM (the bug, `WARN_ON_ONCE` fires)

Both cases correctly set `vma = NULL`, preventing the un-refcounted pointer from being returned at line 904's `if (likely(vma)) return vma;`.

**RCU safety:** The `vma->vm` dereference in the `WARN_ON_ONCE` is safe because we're still inside `rcu_read_lock()`, so the VMA can't be freed underneath us.

**Minor observations:**

1. **Conflict with current tree:** As noted, the drm-next tree already has `else vma = NULL;` at this location. The patch will need a trivial rebase to apply on top of that — essentially just adding the `WARN_ON_ONCE` inside the existing `else` branch. It would be worth confirming who already applied the partial fix and whether that commit should be referenced.

2. **WARN_ON_ONCE appropriateness:** Given Sima's analysis that this condition is impossible to trigger on any kernel with proto-contexts (>= d4433c7600f7), `WARN_ON_ONCE` is the right severity — it shouldn't fire in practice, but if it ever does, it signals a serious regression in the VM invariant. A `drm_WARN_ON_ONCE` passing the `i915` device might be slightly preferred for consistency with the rest of the i915 driver's warning style, but this is a very minor nit.

3. **Commit message quality:** Excellent. The historical analysis, the Fixes tag, the References link to the original report, and the explanation of why it's safe to backport are all thorough and helpful for anyone reading this in `git log` later.

**Verdict:** The patch is correct and ready to merge, pending a trivial rebase against the current tree. Consider using `drm_WARN_ON_ONCE()` instead of `WARN_ON_ONCE()` for i915 driver convention consistency.

---
Generated by Claude Code Patch Reviewer