From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/sysfb: corebootdrm: Support power management Date: Sun, 12 Apr 2026 12:33:54 +1000 Message-ID: In-Reply-To: <20260408120722.328769-2-tzimmermann@suse.de> References: <20260408120722.328769-1-tzimmermann@suse.de> <20260408120722.328769-2-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Correct.** The probe stores `cdev` (a `struct corebootdrm_device *`) as drvdata: ```c platform_set_drvdata(pdev, cdev); /* corebootdrm.c:329 */ ``` The PM callbacks correctly retrieve the same type and navigate to the drm_device: ```c struct corebootdrm_device *cdev = dev_get_drvdata(dev); struct drm_device *drm = &cdev->sysfb.dev; ``` Includes are correct: `` for PM macros, `` for `drm_mode_config_helper_suspend/resume`. No issues. --- Generated by Claude Code Patch Reviewer