From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amd/display: Remove unnecessary SIGNAL_TYPE_HDMI_TYPE_A check Date: Sun, 12 Apr 2026 11:01:40 +1000 Message-ID: In-Reply-To: <20260409-color-format-v12-1-ce84e1817a27@collabora.com> References: <20260409-color-format-v12-0-ce84e1817a27@collabora.com> <20260409-color-format-v12-1-ce84e1817a27@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Author**: Werner Sembach Straightforward cleanup. Removes the HDMI-only guard on the 420-only path and combines the conditions: ```c if (drm_mode_is_420_only(info, mode_in) || (aconnector && aconnector->force_yuv420_output && drm_mode_is_420_also(info, mode_in))) timing_out->pixel_encoding = PIXEL_ENCODING_YCBCR420; ``` This is correct -- there's no reason to refuse YUV420 on non-HDMI if the display reports 420-only. The commit message justification is sound. Has Tested-by from Andri Yngvason. **Verdict**: Good. --- --- Generated by Claude Code Patch Reviewer