From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915/display/intel_sdvo: Fix double connector destroy in error paths Date: Sun, 12 Apr 2026 10:51:24 +1000 Message-ID: In-Reply-To: <20260409-feat_link_cap-v1-1-7069e8199ce2@bootlin.com> References: <20260409-feat_link_cap-v1-0-7069e8199ce2@bootlin.com> <20260409-feat_link_cap-v1-1-7069e8199ce2@bootlin.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Correct fix. After `drm_connector_init_with_ddc()` succeeds in `intel_sdvo_connector_init()`, the DRM core owns the connector via the registered `.destroy` callback (`intel_connector_destroy`). The explicit `intel_connector_destroy()` calls in `intel_sdvo_tv_init()` and `intel_sdvo_lvds_init()` error paths were indeed double-free bugs. The patch simply replaces `goto err` with `return false`, which is correct since the DRM core will handle cleanup during device teardown. Minor nit: "Not tested as I don't have such hardware" -- the Fixes tag references a commit from 2010. Given the age and the SDVO being legacy hardware, this is reasonable but should get an Ack from an Intel maintainer who can verify the ownership model. --- Generated by Claude Code Patch Reviewer