public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: misc: fastrpc: Fix initial memory allocation for Audio PD memory pool
Date: Sun, 12 Apr 2026 11:44:33 +1000	[thread overview]
Message-ID: <review-patch1-20260409062617.1182-2-jianping.li@oss.qualcomm.com> (raw)
In-Reply-To: <20260409062617.1182-2-jianping.li@oss.qualcomm.com>

Patch Review

**Verdict: Looks correct.**

The bug analysis is sound. In the original code, `inbuf.pageslen` is unconditionally set to 0 *after* the remote_heap allocation block:

```c
// Original code (after the allocation/SCM block):
inbuf.client_id = fl->client_id;
inbuf.namelen = init.namelen;
inbuf.pageslen = 0;  // always 0, even if heap was just allocated
```

This means the buffer page info is never passed to the DSP, so the memory pool starts empty and the initial allocation is leaked.

The fix moves the `inbuf` initialization before the allocation block and conditionally sets `pageslen = 1` when SCM assignment succeeds:

```c
inbuf.pageslen = 0;
if (!fl->cctx->remote_heap) {
    // allocate + SCM...
    scm_done = true;
    inbuf.pageslen = 1;  // <-- now set when memory is actually registered
}
```

This correctly distinguishes first-time allocation (pageslen=1, send page info) from subsequent calls where the heap already exists (pageslen=0). Note that Patch 3 later removes and replaces this code entirely, but each patch in the series is independently correct.

**Minor nit:** The blank line after `goto err;` followed by `}` and the removed blank line before `if (!fl->cctx->remote_heap)` changes the spacing slightly. No functional issue.

---

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-04-12  1:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-09  6:26 [PATCH v4 0/4] misc: fastrpc: Add missing bug fixes Jianping Li
2026-04-09  6:26 ` [PATCH v4 1/4] misc: fastrpc: Fix initial memory allocation for Audio PD memory pool Jianping Li
2026-04-12  1:44   ` Claude Code Review Bot [this message]
2026-04-09  6:26 ` [PATCH v4 2/4] misc: fastrpc: Remove buffer from list prior to unmap operation Jianping Li
2026-04-12  1:44   ` Claude review: " Claude Code Review Bot
2026-04-09  6:26 ` [PATCH v4 3/4] misc: fastrpc: Allocate entire reserved memory for Audio PD in probe Jianping Li
2026-04-09  7:54   ` Ekansh Gupta
2026-04-12  1:44   ` Claude review: " Claude Code Review Bot
2026-04-09  6:26 ` [PATCH v4 4/4] misc: fastrpc: Allow fastrpc_buf_free() to accept NULL Jianping Li
2026-04-12  1:44   ` Claude review: " Claude Code Review Bot
2026-04-12  1:44 ` Claude review: misc: fastrpc: Add missing bug fixes Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260409062617.1182-2-jianping.li@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox