From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: MAINTAINERS: Add dedicated entry for fbcon Date: Sun, 12 Apr 2026 11:31:38 +1000 Message-ID: In-Reply-To: <20260409072711.12500-1-tzimmermann@suse.de> References: <20260409072711.12500-1-tzimmermann@suse.de> <20260409072711.12500-1-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Correctness of the entry format:** The entry follows standard MAINTAINERS format correctly -- `M:` for maintainers, `L:` for mailing lists, `S:` for status, `T:` for tree, `F:` for files. All fields are properly formatted. **Maintainers (M:):** Lists Helge Deller and Thomas Zimmermann. Helge is already the maintainer of the FRAMEBUFFER LAYER entry, so his inclusion here is consistent. Thomas is a well-known DRM/fbdev contributor at SUSE. **Mailing lists (L:):** Lists both `dri-devel@lists.freedesktop.org` and `linux-fbdev@vger.kernel.org`, which makes sense since fbcon straddles both DRM and fbdev. **Tree (T:):** Points to `git https://gitlab.freedesktop.org/drm/misc/kernel.git`, matching the FRAMEBUFFER CORE entry. This is the drm-misc tree, which is appropriate since fbcon patches often come through the DRM tree. **File coverage:** All 13 listed files/directories exist in the tree: - `Documentation/fb/fbcon.rst` -- fbcon documentation - `drivers/video/fbdev/core/bitblit.c`, `fb_logo.c`, `fbcon.c`, `fbcon.h`, `fbcon_ccw.c`, `fbcon_cw.c`, `fbcon_rotate.c`, `fbcon_rotate.h`, `fbcon_ud.c`, `softcursor.c`, `tileblit.c` -- all fbcon core files - `include/linux/fbcon.h`, `include/linux/font.h` -- related headers - `lib/fonts/` -- font library directory **Overlap consideration:** The existing FRAMEBUFFER CORE entry uses `F: drivers/video/fbdev/core/` which is a wildcard covering all files in that directory, including the fbcon files now explicitly listed. Similarly, FRAMEBUFFER LAYER uses `F: drivers/video/` and `F: Documentation/fb/` which overlap. This is fine and intentional -- `get_maintainer.pl` handles overlapping entries by reporting all matching maintainers, and having a more specific entry ensures fbcon patches get routed to the right people. The explicit file listing (rather than a wildcard like `F: drivers/video/fbdev/core/fbcon*`) is more verbose but ensures files like `bitblit.c`, `softcursor.c`, and `tileblit.c` that don't start with `fbcon` are correctly captured. **One minor observation:** `include/linux/font.h` and `lib/fonts/` are font-related rather than fbcon-specific, and are also used outside of fbcon (e.g., by DRM drivers for boot logos). Including them here is reasonable since fbcon is the primary consumer, but it's worth noting that patches to `lib/fonts/` will now also CC the fbcon maintainers, which seems appropriate. **Verdict:** Looks good. No changes needed. Reviewed-by for this patch would be appropriate. --- Generated by Claude Code Patch Reviewer