From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: Remove unused header in drm_dumb_buffers.c Date: Sun, 12 Apr 2026 10:55:27 +1000 Message-ID: In-Reply-To: <20260409154826.8955-1-yiconghui@gmail.com> References: <20260409154826.8955-1-yiconghui@gmail.com> <20260409154826.8955-1-yiconghui@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Result: No issues.** The patch removes: ```c -#include "drm_internal.h" ``` I verified this is correct by cross-referencing the symbols used in `drm_du= mb_buffers.c` against the declarations in `drm_internal.h`: - `drm_gem_handle_delete()` =E2=80=94 declared in `` (line 5= 84), **not** in `drm_internal.h` - `drm_gem_dumb_map_offset()` =E2=80=94 declared in ``, **no= t** in `drm_internal.h` - `drm_mode_create_dumb_ioctl()`, `drm_mode_mmap_dumb_ioctl()`, `drm_mode_d= estroy_dumb_ioctl()` =E2=80=94 declared in `drm_crtc_internal.h` (lines 116= -120), which remains included - All other symbols come from the public `` headers already includ= ed No symbol used by `drm_dumb_buffers.c` is declared in `drm_internal.h`. The= remaining include of `drm_crtc_internal.h` covers the internal declaration= s this file needs. The `Fixes:` tag referencing `96a7b60f6ddb` is reasonable =E2=80=94 that's = the commit that removed `drm_gem_dumb_destroy()`, which was the last functi= on requiring `drm_internal.h`. Minor nit: some maintainers might prefer not= to use a `Fixes:` tag for a cosmetic cleanup since nothing is functionally= broken, but this is a matter of style/preference and not worth blocking on. --- Generated by Claude Code Patch Reviewer