From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dma-buf: fix htmldocs error for dma_buf_attach_revocable Date: Sun, 12 Apr 2026 09:39:23 +1000 Message-ID: In-Reply-To: <20260410123703.937822-1-sumit.semwal@linaro.org> References: <20260410123703.937822-1-sumit.semwal@linaro.org> <20260410123703.937822-1-sumit.semwal@linaro.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Status: Looks good (Reviewed-by worthy)** The problem: In the kernel-doc comment for `dma_buf_invalidate_mappings()`,= the text: ```c * accessed: * 1) Until dma_resv_wait_timeout() ... ``` is missing a blank comment line between the paragraph ending in `:` and the= start of the numbered list. The RST parser doesn't recognize the numbered = list without that separator. The fix adds the required blank `*` line: ```c * accessed: * * 1) Until dma_resv_wait_timeout() ... ``` This is the standard kernel-doc convention =E2=80=94 a blank `*` line is ne= eded before a list block for proper RST rendering. I confirmed the current = tree at `drivers/dma-buf/dma-buf.c:1355-1356` has exactly this missing blan= k line. **Minor nit (non-blocking):** The subject says "for dma_buf_attach_revocabl= e" but the comment being fixed is actually on `dma_buf_invalidate_mappings(= )`. The Fixes tag correctly points to the commit that introduced the proble= matic comment, but the subject could be slightly more precise as "fix htmld= ocs error for dma_buf_invalidate_mappings". This is cosmetic and not worth = a respin. No functional or correctness issues. The patch is trivially correct. --- Generated by Claude Code Patch Reviewer