From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panthor: Pass an iomem pointer to GPU register access helpers Date: Sun, 12 Apr 2026 09:38:14 +1000 Message-ID: In-Reply-To: <20260410164637.549145-2-karunika.choo@arm.com> References: <20260410164637.549145-1-karunika.choo@arm.com> <20260410164637.549145-2-karunika.choo@arm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Approach**: Mechanical conversion of `gpu_read/gpu_write` helpers from taking `struct panthor_device *` to `void __iomem *`, with all call sites passing `ptdev->iomem`. This is clean and correct. The conversion is straightforward and the poll timeout macros are properly updated. No concerns. One minor style note: the forward declarations in the PANTHOR_IRQ_HANDLER macro use the new `iomem` parameter before the function definitions appear below the macro. This works because the macro is expanded at instantiation time, but it creates a slight ordering dependency that could confuse readers. Not a blocker. --- Generated by Claude Code Patch Reviewer