Claude review: dma-fence: Clarify external lock use case in dma_fence_init() docs

Claude Code Review Bot
2026-04-11T22:49:37Z

Overall Series Review

Subject: dma-fence: Clarify external lock use case in dma_fence_init() docs
Author: =?UTF-8?q?Ma=C3=ADra=20Canal?= <mcanal@igalia.com>
Patches: 1
Reviewed: 2026-04-12T08:49:37.991345

---

This is a single-patch documentation-only change to the `dma_fence_init()` and `dma_fence_init64()` kerneldoc comments in `drivers/dma-buf/dma-fence.c`. The change is small, well-motivated, and technically accurate.

The existing wording says a shared lock prevents fences "from signaling out of order," which implies the lock somehow enforces ordering. As the author correctly notes, a spinlock cannot enforce ordering — it can only serialize. The driver is still responsible for signaling fences in the correct order. What the shared lock *does* provide is that an observer holding the lock will never see a state where a later fence is signaled while an earlier one is not (because the signaling operations are serialized under the same lock).

The new wording is a clear improvement. No functional code is changed.

**Verdict: Looks good.**

---
Generated by Claude Code Patch Reviewer