public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: staging: fbtft: Use %pe format specifier for error pointers
Date: Mon, 13 Apr 2026 19:00:42 +1000	[thread overview]
Message-ID: <review-patch1-20260412144552.18493-1-mahad.ibrahim.dev@gmail.com> (raw)
In-Reply-To: <20260412144552.18493-1-mahad.ibrahim.dev@gmail.com>

Patch Review

**fb_ssd1351.c change:**
```c
-		"cannot register backlight device (%ld)\n",
-		PTR_ERR(bd));
+		"cannot register backlight device (%pe)\n", bd);
```

**fbtft-core.c change:**
```c
-		"cannot register backlight device (%ld)\n",
-		PTR_ERR(bd));
+		"cannot register backlight device (%pe)\n", bd);
```

Both hunks are correct. In each case `bd` has just been confirmed to be an error pointer via `IS_ERR(bd)`, so passing it directly with `%pe` is safe and will print the symbolic error name (e.g. `-ENOMEM`) instead of a raw number.

**Minor observations (not blocking):**

- The commit message is clear and well-structured. The "Testing" note about compile-only testing is appreciated and appropriate for a printf-format-only change in staging.
- The `Fixes:` tag is absent, which is fine — this is a cosmetic cleanup, not a bug fix, so no `Fixes:` tag is needed. However, the commit message says "Fixes the following coccinelle warnings" which could be slightly misleading since `Fixes:` has a specific meaning in the kernel. Consider rephrasing to "Addresses the following coccinelle warnings" or "Resolves the following coccinelle warning" to avoid any ambiguity, though this is a very minor nit.

**Reviewed-by worthy:** Yes. The patch is trivially correct.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-04-13  9:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-12 14:45 [PATCH] staging: fbtft: Use %pe format specifier for error pointers Mahad Ibrahim
2026-04-13  7:03 ` Andy Shevchenko
2026-04-13  7:49   ` Dan Carpenter
2026-04-13  7:53     ` Andy Shevchenko
2026-04-13  9:00 ` Claude Code Review Bot [this message]
2026-04-13  9:00 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260412144552.18493-1-mahad.ibrahim.dev@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox