From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: staging: fbtft: replace empty macro args with identity converter Date: Mon, 13 Apr 2026 18:56:21 +1000 Message-ID: In-Reply-To: <20260412172147.2817-2-mzndmzn@gmail.com> References: <20260412172147.2817-2-mzndmzn@gmail.com> <20260412172147.2817-2-mzndmzn@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Commit message:** > Remove trailing space and comma before closing parenthesis ')' in define_= fbtft_write_reg macro as reported by checkpatch.pl. **Critical bug =E2=80=94 will not compile.** The macro `define_fbtft_write_= reg` is defined with 4 parameters: ```c #define define_fbtft_write_reg(func, buffer_type, data_type, modifier) ``` But the patch changes the invocations from 4 arguments (with an empty 4th) = to 3: ```c -define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, ) +define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8) ``` Calling a fixed-arity 4-parameter macro with only 3 arguments is a hard err= or from the preprocessor. GCC will emit: `error: macro "define_fbtft_write_= reg" requires 4 arguments, but only 3 given`. The existing code with the empty 4th argument (`, )`) is actually well-defi= ned in C99 and GNU C (which the kernel uses via `-std=3Dgnu11`). An empty m= acro argument is a valid "placemarker" preprocessing token per C99 =C2=A76.= 10.3. When `modifier` is empty, `modifier((data_type)va_arg(args, unsigned = int))` expands to `((data_type)va_arg(args, unsigned int))` =E2=80=94 a cor= rectly parenthesized identity operation. The checkpatch warning is cosmetic= and the existing code is correct. **Verdict:** NAK. This patch introduces a build failure. --- --- Generated by Claude Code Patch Reviewer