From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panel: hx83121a: select DRM_DISPLAY_DSC_HELPER
Date: Mon, 13 Apr 2026 18:44:29 +1000
Message-ID: <review-patch1-20260413071043.3829868-1-arnd@kernel.org>
In-Reply-To: <20260413071043.3829868-1-arnd@kernel.org>
References: <20260413071043.3829868-1-arnd@kernel.org> <20260413071043.3829868-1-arnd@kernel.org>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

**Status: Good to merge**

The problem is clear: `panel-himax-hx83121a.c` includes `<drm/display/drm_d=
sc_helper.h>` and calls `drm_dsc_pps_payload_pack()` at line 116:

```c
drm_dsc_pps_payload_pack(&pps, &ctx->dsc);
```

But the Kconfig entry was missing the corresponding `select DRM_DISPLAY_DSC=
_HELPER`, causing a link-time failure:

```
undefined reference to `drm_dsc_pps_payload_pack'
```

The fix adds the missing `select`:

```diff
+	select DRM_DISPLAY_DSC_HELPER
 	select DRM_KMS_HELPER
```

The placement is correct =E2=80=94 it's inserted alphabetically before `DRM=
_KMS_HELPER`, consistent with how other panel drivers order their `select` =
statements.

The `Fixes:` tag correctly references `a7c61963b727 ("drm/panel: Add Himax =
HX83121A panel driver")`, which is the commit that introduced the driver wi=
th the missing dependency.

No concerns with this patch.

---
Generated by Claude Code Patch Reviewer