From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/connector: report IRQ_HPD events to drm_connector_oob_hotplug_event() Date: Thu, 23 Apr 2026 09:32:09 +1000 Message-ID: In-Reply-To: <20260420-hpd-irq-events-v2-1-402ffe27e9e9@oss.qualcomm.com> References: <20260420-hpd-irq-events-v2-0-402ffe27e9e9@oss.qualcomm.com> <20260420-hpd-irq-events-v2-1-402ffe27e9e9@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review This patch introduces the `enum drm_connector_status_extra` type and extends `drm_connector_oob_hotplug_event()` and all its callers in the USB typec displayport altmode driver. **Looks good overall.** The enum and its documentation are clear. The callers in `displayport.c` are correctly updated. One minor observation: in the `dp_altmode_status_update()` path: ```c drm_connector_oob_hotplug_event(dp->connector_fwnode, hpd ? connector_status_connected : connector_status_disconnected, (hpd && irq_hpd) ? DRM_CONNECTOR_DP_IRQ_HPD : DRM_CONNECTOR_NO_EXTRA_STATUS); ``` This correctly only sends IRQ_HPD when HPD is asserted (since IRQ_HPD without HPD is meaningless per DP spec). Good. Minor nit: the cover letter says "desribing" (typo for "describing") and "chaning" (typo for "changing"), but those are in the changelog, not in code. --- Generated by Claude Code Patch Reviewer