From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/mediatek: hdmi: Convert DRM_ERROR() to drm_err() Date: Thu, 23 Apr 2026 10:15:08 +1000 Message-ID: In-Reply-To: <20260420064544.266478-1-suryasaimadhu369@gmail.com> References: <20260420064544.266478-1-suryasaimadhu369@gmail.com> <20260420064544.266478-1-suryasaimadhu369@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Status: Looks good** The conversion is correct: - `bridge->dev` is `struct drm_device *` (confirmed from `drm_bridge.h:1104= `), which is the correct first argument for `drm_err()`. - The `__func__` prefix was correctly removed =E2=80=94 `drm_err()` already= includes device identification in its output, so the function name is unne= cessary (and the original `__func__` usage was unusual for this kind of err= or message anyway). - After the patch, no `DRM_ERROR` calls remain in `mtk_hdmi.c`, so the conv= ersion is complete for this file. - The error message text is clear and adequate. **Minor nit:** The error message string says `"DRM_BRIDGE_ATTACH_NO_CONNECT= OR must be supplied\n"` =E2=80=94 while this is functionally fine and match= es the flag name, a slightly more descriptive phrasing like `"The flag DRM_= BRIDGE_ATTACH_NO_CONNECTOR must be supplied\n"` (preserving the original's = wording minus `__func__`) would be marginally clearer to someone reading lo= gs. This is very minor and not worth blocking on. **Verdict:** Patch is correct and complete. No issues. --- Generated by Claude Code Patch Reviewer