From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panel: jdi-fhd-r63452: remove panel on DSI attach failure Date: Thu, 23 Apr 2026 10:13:55 +1000 Message-ID: In-Reply-To: <20260420065305.8781-1-mhun512@gmail.com> References: <20260420065305.8781-1-mhun512@gmail.com> <20260420065305.8781-1-mhun512@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Correctness:** The fix is correct. Looking at the probe function: ```c drm_panel_add(&ctx->panel); // line 203 ret =3D mipi_dsi_attach(dsi); // line 205 if (ret < 0) { dev_err(dev, "Failed to attach to DSI host: %d\n", ret); return ret; // BUG: panel left in global list } ``` `devm_drm_panel_alloc()` registers a devm action for `drm_panel_put()` but = does NOT handle `drm_panel_remove()` =E2=80=94 the `drm_panel_add()`/`drm_p= anel_remove()` lifecycle is the driver's responsibility. The `.remove()` ca= llback at line 214 calls `drm_panel_remove()`, but that path is never taken= when probe fails. So the added `drm_panel_remove()` call is the correct fi= x. **Commit message:** The commit message clearly explains the problem and sol= ution. However: - **Missing `Fixes:` tag.** This is a bugfix and should reference the commi= t that introduced the bug. This is important for stable-kernel backporting.= The commit that introduced the driver (or that converted it to `devm_drm_p= anel_alloc` without adding error-path cleanup) should be cited. **Style:** The patch is minimal and well-placed =E2=80=94 exactly one line = in the right location. **Nit:** The blank line between "If mipi_dsi_attach() fails, the driver ret= urns without calling" and "drm_panel_remove()" in the commit message body (= lines 101-102 of the mbox) appears to be an unintentional line break splitt= ing a sentence across paragraphs. It should read as a continuous paragraph. --- Generated by Claude Code Patch Reviewer