From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panel: lg-sw43408: remove panel on DSI attach failure
Date: Thu, 23 Apr 2026 10:12:25 +1000
Message-ID: <review-patch1-20260420073945.65849-1-mhun512@gmail.com>
In-Reply-To: <20260420073945.65849-1-mhun512@gmail.com>
References: <20260420073945.65849-1-mhun512@gmail.com> <20260420073945.65849-1-mhun512@gmail.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

**Correctness: Good.** The error handling properly captures the return value of `mipi_dsi_attach()` and calls `drm_panel_remove()` before returning the error:

```c
-	return mipi_dsi_attach(dsi);
+	ret = mipi_dsi_attach(dsi);
+	if (ret < 0) {
+		drm_panel_remove(&ctx->base);
+		return ret;
+	}
+
+	return 0;
```

This correctly mirrors the cleanup done in `sw43408_remove()` (line 309 of the existing file), where `drm_panel_remove(&ctx->base)` is called after `mipi_dsi_detach()`.

**Minor nits:**

1. **Commit message formatting**: The `In-Reply-To:` and `References:` headers contain `<Casey Connolly <casey.connolly@linaro.org>` which is a malformed Message-ID (should be an actual Message-ID like `<xxxx@host>`). This is a mailing list metadata issue, not a code issue, but suggests the patch was sent as a reply to a message without properly quoting the Message-ID.

2. **Style**: `return 0` at the end is fine. An alternative would be `return ret` (since `ret` is 0 on the success path), but the explicit `return 0` is arguably clearer and matches the convention in other panel drivers.

3. **Scope**: The patch is narrowly focused on fixing exactly one bug. No unnecessary changes.

**No issues found with the code change itself.** The fix is minimal, correct, and well-explained in the commit message.

---
Generated by Claude Code Patch Reviewer