public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/hibmc: Use drm_atomic_helper_check_plane_state()
Date: Thu, 23 Apr 2026 10:03:22 +1000	[thread overview]
Message-ID: <review-patch1-20260420121130.200133-2-tzimmermann@suse.de> (raw)
In-Reply-To: <20260420121130.200133-2-tzimmermann@suse.de>

Patch Review

**Status: Good**

This replaces a hand-rolled plane state check with the standard `drm_atomic_helper_check_plane_state()` helper. The conversion is correct:

```c
ret = drm_atomic_helper_check_plane_state(new_plane_state, new_crtc_state,
                                          DRM_PLANE_NO_SCALING,
                                          DRM_PLANE_NO_SCALING,
                                          false, true);
```

- `can_position=false` (4th arg) correctly enforces that the plane must cover the full CRTC, preserving the original behavior where the plane had to match the display exactly.
- `can_update_disabled=true` (5th arg) allows check to proceed even with a disabled CRTC, which is cleaner than the old early return on `!crtc_state->enable`.
- Using `drm_atomic_get_new_crtc_state()` (read-only) instead of the old `drm_atomic_get_crtc_state()` (which adds/locks) is the correct modern pattern. The CRTC state is always already present at this point because `drm_atomic_helper_check_modeset()` runs before `drm_atomic_helper_check_planes()`.

The commit message notes that the visibility check is slightly relaxed (plane can now be *larger* than the CRTC, not just exactly equal). This is a correct behavioral change and well-documented.

The 128-byte pitch alignment check is preserved, which is important for hardware correctness.

No issues.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-04-23  0:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-20 12:09 [PATCH v2 0/4] drm/hibmc: Fix plane helpers and convert to gem-shmem Thomas Zimmermann
2026-04-20 12:09 ` [PATCH v2 1/4] drm/hibmc: Use drm_atomic_helper_check_plane_state() Thomas Zimmermann
2026-04-21  7:56   ` Yongbang Shi
2026-04-23  0:03   ` Claude Code Review Bot [this message]
2026-04-20 12:09 ` [PATCH v2 2/4] drm/hibmc: Fix list of formats on the primary plane Thomas Zimmermann
2026-04-23  0:03   ` Claude review: " Claude Code Review Bot
2026-04-20 12:09 ` [PATCH v2 3/4] drm/hibmc: Do not use cpp from struct drm_format_info Thomas Zimmermann
2026-04-23  0:03   ` Claude review: " Claude Code Review Bot
2026-04-20 12:10 ` [PATCH v2 4/4] drm/hibmc: Use gem-shmem with shadow-plane helpers for memory management Thomas Zimmermann
2026-04-23  0:03   ` Claude review: " Claude Code Review Bot
2026-04-23  0:03 ` Claude review: drm/hibmc: Fix plane helpers and convert to gem-shmem Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260420121130.200133-2-tzimmermann@suse.de \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox