From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/vkms: Clean up artifacts from old vblank timer Date: Thu, 23 Apr 2026 09:36:04 +1000 Message-ID: In-Reply-To: <20260420131831.242882-1-tzimmermann@suse.de> References: <20260420131831.242882-1-tzimmermann@suse.de> <20260420131831.242882-1-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Changes reviewed:** 1. **`vkms_drv.h`: Remove `#include `** =E2=80=94 Correct.= No struct members or function signatures in this header use `hrtimer_*` ty= pes after the conversion. The include is dead. 2. **`vkms_drv.h`: Remove kernel-doc for `vblank_hrtimer` and `period_ns`**= =E2=80=94 Correct. These fields were removed in `02e2681ffe1a` but their d= ocumentation was left behind. Removing orphaned kernel-doc entries is the r= ight cleanup. 3. **`vkms_composer.c` line 597**: Comment update from `vkms_vblank_simulat= e()` to `vkms_crtc_handle_vblank_timeout()` =E2=80=94 Correct. `vkms_crtc_h= andle_vblank_timeout` exists in `vkms_crtc.c:16` and is the current functio= n name. 4. **`vkms_composer.c` line 639**: Comment update from "vblank hrtimer" to = "vblank timer" =E2=80=94 Correct. **Issue =E2=80=94 missed stale reference:** There is a third "hrtimer" comment in `vkms_composer.c` at line 662 that wa= s not updated: ```c /* * The worker can fall behind the vblank hrtimer, make sure we catch up. */ ``` This should be changed to "vblank timer" for consistency with the other com= ment fix in this same patch. Since the stated goal of the patch is to "fix = comments referring to the original implementation," this seems like an over= sight. **Nit:** The `Fixes:` tag is arguably unnecessary here =E2=80=94 this is a = comment/include cleanup, not a functional fix. It won't cause backporting c= onfusion since the referenced commit is recent, but `Fixes:` typically impl= ies a behavioral/correctness issue that stable kernels should pick up. This= is minor and a matter of project convention. --- Generated by Claude Code Patch Reviewer