From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: fbdev: cobalt_lcdfb: Request memory region
Date: Thu, 23 Apr 2026 09:34:40 +1000
Message-ID: <review-patch1-20260420134424.77494-2-amit.barzilai22@gmail.com>
In-Reply-To: <20260420134424.77494-2-amit.barzilai22@gmail.com>
References: <20260420134424.77494-1-amit.barzilai22@gmail.com> <20260420134424.77494-2-amit.barzilai22@gmail.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

**Status: Good**

Replaces separate `platform_get_resource()` + `devm_ioremap()` with a single `devm_platform_get_and_ioremap_resource()` call. The conversion is correct:

```c
info->screen_base = devm_platform_get_and_ioremap_resource(dev, 0, &res);
if (IS_ERR(info->screen_base)) {
    framebuffer_release(info);
    return PTR_ERR(info->screen_base);
}
```

The `res` output parameter is correctly used on the following line (`info->screen_size = resource_size(res)`), and the reordering (screen_base assigned before screen_size) is fine since `screen_size` is not needed for the mapping itself.

The original code returned `-EBUSY` when the resource wasn't found, which was arguably the wrong error code. The new code will return the actual error from the helper (likely `-EINVAL`), which is a minor improvement.

No issues.

---
Generated by Claude Code Patch Reviewer