From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: Fix DYNAMIC_DEBUG_MODULE propagation to subdirectories Date: Thu, 23 Apr 2026 08:49:03 +1000 Message-ID: In-Reply-To: <20260420160425.3919114-1-sean@poorly.run> References: <20260420160425.3919114-1-sean@poorly.run> <20260420160425.3919114-1-sean@poorly.run> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Correctness: Good.** The two changes are: ```makefile -CFLAGS-$(CONFIG_DRM_USE_DYNAMIC_DEBUG) +=3D -DDYNAMIC_DEBUG_MODULE +ccflags-$(CONFIG_DRM_USE_DYNAMIC_DEBUG) +=3D -DDYNAMIC_DEBUG_MODULE +subdir-ccflags-$(CONFIG_DRM_USE_DYNAMIC_DEBUG) +=3D -DDYNAMIC_DEBUG_MODULE ``` 1. `CFLAGS-y` is not a kbuild-recognized variable =E2=80=94 this was simply= dead code. Changing to `ccflags-y` is the correct fix (per `Documentation/= kbuild/makefiles.rst:321`). 2. Adding `subdir-ccflags-y` propagates the flag to all subdirectories unde= r `drivers/gpu/drm/`, which is essential since DRM drivers live in subdirec= tories like `amd/`, `i915/`, `nouveau/`, etc. Without this, files calling `= drm_dbg()` and friends in those subdirectories would still get implicit-dec= laration errors for `_dynamic_func_call_cls`. **Minor observation:** Per the kbuild documentation (`makefiles.rst:352-355= `), `subdir-ccflags-y` applies to "*the kbuild file where they are present = and all subdirectories*" =E2=80=94 meaning it already covers the current di= rectory. So the `ccflags-y` line is technically redundant; `subdir-ccflags-= y` alone would suffice. This is harmless (duplicate `-D` flags for files di= rectly in `drivers/gpu/drm/` don't cause problems), and being explicit abou= t both scopes is a reasonable style choice. Not worth blocking over. **Commit message:** Clear and accurate. The Fixes tag correctly references = the commit that introduced the original `CFLAGS-y` typo. The note about `de= pends on BROKEN` is helpful context. **Reviewed-by worthy:** Yes =E2=80=94 this is a correct, minimal fix. --- Generated by Claude Code Patch Reviewer