From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/connector: report IRQ_HPD events to drm_connector_oob_hotplug_event() Date: Thu, 23 Apr 2026 09:07:42 +1000 Message-ID: In-Reply-To: <20260421-hpd-irq-events-v3-1-44d2bf40dfc2@oss.qualcomm.com> References: <20260421-hpd-irq-events-v3-0-44d2bf40dfc2@oss.qualcomm.com> <20260421-hpd-irq-events-v3-1-44d2bf40dfc2@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Design:** The new `enum drm_connector_status_extra` is well-defined with good kerneldoc. Using a separate enum rather than overloading `drm_connector_status` is the right call -- these are orthogonal concepts (connection state vs. event type). **drm_connector.c change** -- clean and minimal. The function signature gains the extra parameter, which is threaded through to `connector->funcs->oob_hotplug_event()` (done later in patch 2). **displayport.c changes** -- the logic is correct: ```c (hpd && irq_hpd) ? DRM_CONNECTOR_DP_IRQ_HPD : DRM_CONNECTOR_NO_EXTRA_STATUS ``` IRQ_HPD only makes sense when HPD is asserted (connected), so the `hpd && irq_hpd` guard is correct per the DP spec. The disconnect paths correctly pass `DRM_CONNECTOR_NO_EXTRA_STATUS`. The `dp_altmode_configured()` path correctly uses `dp->pending_irq_hpd` for deferred HPD events. No issues. **Nit:** The cover letter has "singnalling" (typo for "signalling"). --- Generated by Claude Code Patch Reviewer