From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/tegra: fbdev: Do not assign to struct drm_fb_helper.info Date: Thu, 23 Apr 2026 08:46:58 +1000 Message-ID: In-Reply-To: <20260421073646.144712-2-tzimmermann@suse.de> References: <20260421073646.144712-1-tzimmermann@suse.de> <20260421073646.144712-2-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Status: Good** The removed assignment is redundant. `info` is initialized from `helper->in= fo` at the top of the function: ```c struct fb_info *info =3D helper->info; ``` So `helper->info =3D info;` assigns the field back to itself. The Fixes tag= referencing `63c971af4036` ("drm/fb-helper: Allocate and release fb_info i= n single place") is appropriate =E2=80=94 that commit made the framework al= locate `helper->info`, making the driver assignment redundant. No issues. --- Generated by Claude Code Patch Reviewer