From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm: Do not declare msm_framebuffer_init() as static Date: Thu, 23 Apr 2026 08:30:52 +1000 Message-ID: In-Reply-To: <20260421125733.209568-2-tzimmermann@suse.de> References: <20260421125733.209568-1-tzimmermann@suse.de> <20260421125733.209568-2-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Status: Looks good.** This is a straightforward scaffolding patch. It removes the forward declaration of `msm_framebuffer_init()` as static, adds the declaration to `msm_drv.h`, and reorders the functions in `msm_fb.c` so that `msm_framebuffer_init()` is defined before `msm_framebuffer_create()`. This eliminates the need for the forward declaration and prepares for patch 2 to call `msm_framebuffer_init()` from `msm_fbdev.c`. The code move is a pure reorder with no functional changes. The new declaration in `msm_drv.h` matches the function signature. Clean. --- Generated by Claude Code Patch Reviewer