From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: misc: fastrpc: Move fdlist to invoke context structure Date: Thu, 23 Apr 2026 07:50:44 +1000 Message-ID: In-Reply-To: <20260422092409.4107093-2-ekansh.gupta@oss.qualcomm.com> References: <20260422092409.4107093-1-ekansh.gupta@oss.qualcomm.com> <20260422092409.4107093-2-ekansh.gupta@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Assessment: Looks good with one minor observation.** This patch moves the `fdlist` pointer from being recalculated in `fastrpc_put_args()` to being computed once in `fastrpc_get_args()` and stored in the context structure. This is a clean refactoring. The original `fastrpc_put_args()` computed the fdlist as: ```c fdlist = (uint64_t *)(pages + inbufs + outbufs + handles); ``` The new code in `fastrpc_get_args()` computes: ```c ctx->fdlist = (u64 *)(pages + ctx->nscalars); ``` Since `ctx->nscalars = inbufs + outbufs + handles`, these are equivalent. The patch also removes `outbufs`, `handles`, `list`, and `pages` local variables from `fastrpc_put_args()` that are no longer needed. **No issues found.** --- --- Generated by Claude Code Patch Reviewer