From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: adv7511: Clear HPD IRQ during atomic_enable() Date: Thu, 23 Apr 2026 07:43:34 +1000 Message-ID: In-Reply-To: <20260422121457.166780-1-biju.das.jz@bp.renesas.com> References: <20260422121457.166780-1-biju.das.jz@bp.renesas.com> <20260422121457.166780-1-biju.das.jz@bp.renesas.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Correctness**: The fix is sound. The `ADV7511_REG_INT(0)` register (addre= ss 0x96) uses write-1-to-clear semantics =E2=80=94 writing `ADV7511_INT0_HP= D` (BIT(7)) clears only the HPD status bit without affecting other interrup= t status bits. This is consistent with how the driver already clears interr= upts in `adv7511_irq_process()`: ```c regmap_write(adv7511->regmap, ADV7511_REG_INT(0), irq0); regmap_write(adv7511->regmap, ADV7511_REG_INT(1), irq1); ``` and in `adv7511_hpd()`: ```c regmap_write(adv7511->regmap, ADV7511_REG_INT(0), ADV7511_INT0_HPD); ``` **Placement**: Correct. The clear happens after `adv7511_power_on()`, which= powers up the chip and re-enables interrupt generation via `ADV7511_REG_IN= T_ENABLE(0)`, but does not itself clear any pending status bits. Clearing a= fter power-on ensures the chip is responsive to the register write. **Scope**: The patch clears only the HPD bit, not other potential stale int= errupt bits (EDID_READY, DDC_ERROR, etc.). This is reasonable =E2=80=94 HPD= is the one specifically reported as causing problems. If other stale inter= rupts turn out to be an issue, a follow-up could clear all of INT(0) and IN= T(1), but there's no reason to over-broaden the fix now. **Minor observation**: The comment is slightly verbose at 4 lines for what = is a single write-1-to-clear operation, but it does explain the *why* (stal= e state across power loss), which is the right kind of comment to include s= ince the reason isn't obvious from the code alone. **No issues found.** The patch is a clean, minimal, well-targeted fix. --- Generated by Claude Code Patch Reviewer