From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panthor: Expose GPU page sizes to UM Date: Thu, 23 Apr 2026 07:41:44 +1000 Message-ID: In-Reply-To: <20260422122538.3117380-2-adrian.larumbe@collabora.com> References: <20260422122538.3117380-1-adrian.larumbe@collabora.com> <20260422122538.3117380-2-adrian.larumbe@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review This patch exposes the MMU page size bitmap to userspace via a new `DRM_PAN= THOR_DEV_QUERY_MMU_INFO` query type and `struct drm_panthor_mmu_info`. **uAPI enum value collision (major):** The new enum member is inserted betw= een `DRM_PANTHOR_DEV_QUERY_CSIF_INFO` and `DRM_PANTHOR_DEV_QUERY_TIMESTAMP_= INFO`. Since the enum is auto-numbered (only `GPU_INFO =3D 0` has an explic= it value), this shifts the values of `TIMESTAMP_INFO` (2=E2=86=923) and `GR= OUP_PRIORITIES_INFO` (3=E2=86=924). Any existing userspace compiled with th= e old header will send the wrong query type for those two. ```c + /** @DRM_PANTHOR_DEV_QUERY_MMU_INFO: Query MMU information. */ + DRM_PANTHOR_DEV_QUERY_MMU_INFO, + /** @DRM_PANTHOR_DEV_QUERY_TIMESTAMP_INFO: Query timestamp information. */ DRM_PANTHOR_DEV_QUERY_TIMESTAMP_INFO, ``` The new member should be appended **after** `DRM_PANTHOR_DEV_QUERY_GROUP_PR= IORITIES_INFO` to preserve existing numeric values, or assigned an explicit= value. The rest of the patch is straightforward =E2=80=94 `panthor_mmu_info_init()= ` sets the bitmap, the ioctl copies it out. Reviewed-by tags from Steven Pr= ice and Boris Brezillon are present. --- Generated by Claude Code Patch Reviewer