From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: backlight: cgbc: Remove redundant X86 dependency Date: Tue, 28 Apr 2026 14:50:33 +1000 Message-ID: In-Reply-To: <20260427-backlight-cgbc-remove-x86-dependency-v2-1-da9f2375a34a@bootlin.com> References: <20260427-backlight-cgbc-remove-x86-dependency-v2-0-da9f2375a34a@bootlin.com> <20260427-backlight-cgbc-remove-x86-dependency-v2-1-da9f2375a34a@bootlin.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Verdict: Good to go.** The change removes `&& X86` from the `BACKLIGHT_CGBC` Kconfig entry: ``` - depends on MFD_CGBC && X86 + depends on MFD_CGBC ``` This is correct. `MFD_CGBC` is defined in `drivers/mfd/Kconfig:241-244` as: ``` config MFD_CGBC tristate "Congatec Board Controller" select MFD_CORE depends on X86 ``` Since `MFD_CGBC` already depends on `X86`, any symbol that `depends on MFD_= CGBC` transitively inherits the X86 constraint =E2=80=94 the explicit `X86`= in the backlight Kconfig was redundant. This is consistent with how the ot= her CGBC sub-drivers (watchdog, gpio, hwmon, i2c) are already written =E2= =80=94 none of them add an explicit `X86` dependency alongside `MFD_CGBC`. One minor observation: the help text still says "x86-based boards", which i= s fine =E2=80=94 it's describing the hardware, not a Kconfig constraint. --- Generated by Claude Code Patch Reviewer