From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dma-buf: heaps: Export mem_accounting parameter Date: Tue, 28 Apr 2026 14:45:01 +1000 Message-ID: In-Reply-To: <20260427-dma-buf-heaps-as-modules-v5-1-b6f5678feefc@kernel.org> References: <20260427-dma-buf-heaps-as-modules-v5-0-b6f5678feefc@kernel.org> <20260427-dma-buf-heaps-as-modules-v5-1-b6f5678feefc@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Change:** Adds `EXPORT_SYMBOL_NS_GPL(mem_accounting, "DMA_BUF_HEAP")` after the existing `module_param` declaration in `drivers/dma-buf/dma-heap.c`. This is correct and necessary. The `mem_accounting` variable is declared `extern` in `include/linux/dma-heap.h:49` and is used by `system_heap.c:388`. Without this export, building `system_heap.c` as a module would fail at link time. Using `_NS_GPL` with the `"DMA_BUF_HEAP"` namespace is consistent with the existing export namespace for the dma-buf heap APIs. Note that `cma_heap.c` does not currently reference `mem_accounting`, so this export is strictly needed only for the system heap (patch 3), not the CMA heap (patch 2). The ordering is still correct since patch 1 logically prepares the infrastructure for both module conversions. No issues. --- Generated by Claude Code Patch Reviewer