From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panel: visionox-rm69299: Split DSI commands out into enable/disable Date: Tue, 28 Apr 2026 14:33:55 +1000 Message-ID: In-Reply-To: <20260427-visionox-rm69299-enable-v1-1-fa7d62d26d87@sigxcpu.org> References: <20260427-visionox-rm69299-enable-v1-0-fa7d62d26d87@sigxcpu.org> <20260427-visionox-rm69299-enable-v1-1-fa7d62d26d87@sigxcpu.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review This is the substantive fix. The init sequence, `exit_sleep_mode`, `set_dis= play_on` move from `prepare` to a new `enable` callback, and `set_display_o= ff`, `enter_sleep_mode` move from `unprepare` to a new `disable` callback. = The remaining `prepare`/`unprepare` become thin wrappers around `power_on`/= `power_off`. The code motion is faithful =E2=80=94 no logic changes, same delays, same L= PM flag manipulation. The fix is correct: DSI commands must be sent after t= he video pipeline is up (`enable`) and before it goes down (`disable`), not= during power sequencing. One minor style observation on the funcs struct: ```c static const struct drm_panel_funcs visionox_rm69299_drm_funcs =3D { .unprepare =3D visionox_rm69299_unprepare, .disable =3D visionox_rm69299_disable, .prepare =3D visionox_rm69299_prepare, .enable =3D visionox_rm69299_enable, .get_modes =3D visionox_rm69299_get_modes, }; ``` The alignment with extra spaces (`.disable =3D`, `.prepare =3D`) is inc= onsistent with the rest of the file and not standard kernel style. Tabs-onl= y alignment or no padding would be more conventional. Very minor. No functional issues. --- Generated by Claude Code Patch Reviewer