From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: display/msm: Fix typo in clock-names property Date: Tue, 28 Apr 2026 14:29:39 +1000 Message-ID: In-Reply-To: <20260427154658.276737-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260427154658.276737-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20260427154658.276737-1-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Status: Reviewed-by worthy** The patch changes five occurrences of the misspelled property `clocks-names= ` to the correct `clock-names` in `Documentation/devicetree/bindings/displa= y/msm/dp-controller.yaml`. **What was broken:** The `allOf` conditional blocks for various SoCs (sc718= 0, sc7280, sc8280xp, x1e80100, sc8180x, sdm845, sm8350, sm8650, sa8775p, gl= ymur) contained: ```yaml - clocks-names: + clock-names: ``` Since the top-level `properties` block at line 102 correctly defines `clock= -names`, and the `required` list at line 185 correctly references `clock-na= mes`, these misspelled conditional constraints were being silently ignored = by the schema validator. DT files could pass validation even if they had th= e wrong number of clock names for their compatible string. **Correctness:** After the patch, all references in the file consistently u= se `clock-names` (confirmed by grep =E2=80=94 8 occurrences, zero `clocks-n= ames` remaining). The change is purely mechanical =E2=80=94 no semantic or = structural changes. **One minor note:** The commit message and patch are well-formed. The `Note= , patch applies on top of next-20260427` is useful context for the maintain= er. No issues found. --- Generated by Claude Code Patch Reviewer