From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: power: supply: sgm41542: document sgm41542
Date: Tue, 28 Apr 2026 14:19:02 +1000
Message-ID: <review-patch1-20260427170914.5062-2-macroalpha82@gmail.com>
In-Reply-To: <20260427170914.5062-2-macroalpha82@gmail.com>
References: <20260427170914.5062-1-macroalpha82@gmail.com> <20260427170914.5062-2-macroalpha82@gmail.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

Looks reasonable overall.

- The `constant-charge-current-max-microamp = <10000000>` (10A) in the example seems extremely high for a single-cell battery charger. The SGM41542 datasheet max charge current is 3780mA. This looks like a copy-paste from the DTS where the BSP value is used without validation. Consider using a realistic value in the example.

```yaml
constant-charge-current-max-microamp = <10000000>;
```

- Missing `#include` ordering: the example has `#include` directives after the battery node definition, which is unconventional. The includes should come before the body.

```yaml
    battery: battery {
      ...
    };
    #include <dt-bindings/gpio/gpio.h>
    #include <dt-bindings/interrupt-controller/irq.h>
```

---
Generated by Claude Code Patch Reviewer