From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dma-buf: heaps: use max3() in dma_heap_ioctl Date: Tue, 28 Apr 2026 14:15:58 +1000 Message-ID: In-Reply-To: <20260427172519.417333-3-thorsten.blum@linux.dev> References: <20260427172519.417333-3-thorsten.blum@linux.dev> <20260427172519.417333-3-thorsten.blum@linux.dev> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Status:** Looks good. The change replaces: ```c ksize = max(max(in_size, out_size), drv_size); ``` with: ```c ksize = max3(in_size, out_size, drv_size); ``` This is a straightforward substitution. `max3()` is defined in `include/linux/minmax.h:152` and is available in this compilation unit through the existing include chain. The three arguments (`in_size`, `out_size`, `drv_size`) are all the same type (`unsigned int` derived from the ioctl size encoding), so there are no type-promotion surprises. The commit message is accurate and concise. The Signed-off-by is present. **Reviewed-by worthy:** Yes, no issues found. --- Generated by Claude Code Patch Reviewer