From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: accel: Arm Ethos-U NPU: fix all uapi kernel-doc warnings
Date: Tue, 28 Apr 2026 14:03:30 +1000
Message-ID: <review-patch1-20260427184121.680672-1-rdunlap@infradead.org>
In-Reply-To: <20260427184121.680672-1-rdunlap@infradead.org>
References: <20260427184121.680672-1-rdunlap@infradead.org> <20260427184121.680672-1-rdunlap@infradead.org>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

**Status: Good to merge**

The patch addresses four categories of kernel-doc issues:

**1. Struct name corrections (correct)**

```c
- * struct drm_ethosu_gpu_info - NPU information
+ * struct drm_ethosu_npu_info - NPU information
```
The actual struct is `drm_ethosu_npu_info` =E2=80=94 the doc comment had a =
stale name `drm_ethosu_gpu_info`. Correct fix.

```c
- * struct drm_ethosu_wait_bo - ioctl argument for waiting for
+ * struct drm_ethosu_bo_wait - ioctl argument for waiting for
```
The actual struct is `drm_ethosu_bo_wait` =E2=80=94 the doc comment had the=
 name segments reversed. Correct fix.

**2. Member name correction (correct)**

```c
-	/** @gpu_rev: GPU revision. */
+	/** @config: NPU revision. */
 	__u32 config;
```
The field is named `config`, not `gpu_rev`. The description is also updated=
 from "GPU revision" to "NPU revision", which is consistent with the rest o=
f the header that uses "NPU" terminology throughout (the device is an NPU, =
not a GPU). Correct fix.

**3. Missing `@member` annotations added (correct)**

For `drm_ethosu_npu_info`:
```c
+	/** @sram_size: NPU SRAM size (KB) */
 	__u32 sram_size;
```

For `drm_ethosu_bo_wait`:
```c
+	/** @handle: BO handle */
 	__u32 handle;
+	/** @pad: Reserved, must be zero. */
 	__u32 pad;
-	__s64 timeout_ns;	/* absolute */
+	/** @timeout_ns: Absolute timeout in ns. */
+	__s64 timeout_ns;
```
Note: `timeout_ns` previously had an inline comment `/* absolute */` which =
is replaced by a proper kernel-doc annotation with the same information. Go=
od.

For `drm_ethosu_job`:
```c
-	/** Input: BO handle for cmdstream. */
+	/** @cmd_bo: Input: BO handle for cmdstream. */
...
-	/** Input: Amount of SRAM to use. */
+	/** @sram_size: Input: Amount of SRAM to use. */
...
-	/** Input: Array of BO handles for each region. */
+	/** @region_bo_handles: Input: Array of BO handles for each region. */
```

For `drm_ethosu_submit`:
```c
-	/** Input: Pointer to an array of struct drm_ethosu_job. */
+	/** @jobs: Input: Pointer to an array of struct drm_ethosu_job. */
...
-	/** Input: Number of jobs passed in. */
+	/** @job_count: Input: Number of jobs passed in. */
...
-	/** Reserved, must be zero. */
+	/** @pad: Reserved, must be zero. */
```

All member name annotations correctly match the actual field names in each =
struct. The existing description text is preserved in every case.

**Minor nits (not worth a respin):**

- `@sram_size: NPU SRAM size (KB)` is missing a trailing period, while othe=
r descriptions like `@pad: Reserved, must be zero.` and `@timeout_ns: Absol=
ute timeout in ns.` have one. This is a very minor inconsistency already pr=
esent in the existing `@handle: BO handle` line as well.
- `struct drm_ethosu_cmdstream_bo_create` (lines 179-194 in the post-patch =
file) still lacks kernel-doc formatted comments =E2=80=94 its members use p=
lain `/* */` comments without `@member:` prefixes. This is pre-existing and=
 out of scope for this patch, but could be a follow-up.

**No functional concerns.** The commit message is well-structured, listing =
all warnings that are resolved. The Signed-off-by is present. Reviewed-by o=
r Acked-by from the Ethos-U maintainer (Rob Herring or Tomeu Vizoso) would =
be nice but is not strictly required for a doc-only fix.

---
Generated by Claude Code Patch Reviewer