From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/tegra: dp: fix kernel-doc warnings in dp.h Date: Tue, 28 Apr 2026 14:01:51 +1000 Message-ID: In-Reply-To: <20260427184442.693768-1-rdunlap@infradead.org> References: <20260427184442.693768-1-rdunlap@infradead.org> <20260427184442.693768-1-rdunlap@infradead.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Status: Clean** The patch fixes four distinct kernel-doc issues: 1. **Missing `@` prefix on `tps3_supported`** (line 103 of the diff): ```c - * tps3_supported: + * @tps3_supported: ``` Correct =E2=80=94 kernel-doc requires `@` prefix for struct member docum= entation. 2. **Empty descriptions for `@apply_training` and `@configure`** (lines 113= , 119 of the diff): ```c - * @apply_training: + * @apply_training: apply the link training ``` ```c - * @configure: + * @configure: configure the DP link ``` Correct =E2=80=94 kernel-doc warns when `@member:` entries in a struct/o= ps doc block have no description text. The added descriptions are brief and= appropriate. 3. **Misplaced nested struct member docs for `aux_rd_interval`** (lines 126= =E2=80=93141 of the diff): The old code had `@cr` and `@ce` documented in a separate `/** */` block= directly above the anonymous struct, which kernel-doc doesn't associate wi= th the parent struct's doc block. The fix removes that orphaned comment and= instead documents `aux_rd_interval.cr` and `aux_rd_interval.ce` as nested = member entries in the parent `struct drm_dp_link` doc block: ```c + * @aux_rd_interval.cr: clock recovery read interval + * @aux_rd_interval.ce: channel equalization read interval ``` This is the correct kernel-doc syntax for anonymous nested struct member= s, and eliminates both the "Excess struct member 'cr'" warning and the impl= icit missing-member warnings. All four fixes are correct kernel-doc usage. The patch is well-scoped =E2= =80=94 it changes only documentation, no functional code. The commit messag= e clearly lists all four warnings being fixed. The Acked-by from Mikko Pert= tunen is appropriate as the Tegra driver maintainer. No concerns with this patch. --- Generated by Claude Code Patch Reviewer