From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/tegra: tegra_drm.h: fix all uapi kernel-doc warnings
Date: Tue, 28 Apr 2026 14:00:47 +1000
Message-ID: <review-patch1-20260427184454.693794-1-rdunlap@infradead.org>
In-Reply-To: <20260427184454.693794-1-rdunlap@infradead.org>
References: <20260427184454.693794-1-rdunlap@infradead.org> <20260427184454.693794-1-rdunlap@infradead.org>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

**Struct member descriptions (lines 307, 325 in patched file):**

The two added descriptions fix the documented warnings for `cmdbuf` and `ta=
rget` members of `struct drm_tegra_reloc`:

```c
/** @cmdbuf: cmd information */
struct {
```

```c
/** @target: relocate target information */
struct {
```

These are correct and silence the warnings. Minor nit: `"cmd information"` =
is quite vague =E2=80=94 something like `"command buffer location"` would b=
etter match the sub-fields (`handle` and `offset` into the command buffer),=
 but this is a stylistic preference and the existing text is adequate.

**Define constant comments (lines 782=E2=80=93861 in patched file):**

The four `#define` comments are converted from bare `/**` blocks (which the=
 kernel-doc parser flags as malformed) to proper `define MACRO - descriptio=
n` form. For example:

```c
/**
 * define DRM_TEGRA_SUBMIT_CMD_GATHER_UPTR - \
 *    Execute Host1x opcodes from user pointer.
 *
 * Execute `words` words of Host1x opcodes specified in the `gather_data_pt=
r`
 * buffer. Each GATHER_UPTR command uses successive words from the buffer.
 */
#define DRM_TEGRA_SUBMIT_CMD_GATHER_UPTR		0
```

The `\` line-continuation on the first `define` line is used to keep line l=
ength manageable, particularly for `DRM_TEGRA_SUBMIT_RELOC_SECTOR_LAYOUT`. =
This works with the kernel-doc script's line-joining logic, so it should pa=
rse correctly. The added short descriptions (`"Select sector layout swizzli=
ng..."`, `"Execute Host1x opcodes..."`, `"Wait for syncpoint (absolute)."`,=
 `"Wait for syncpoint (relative)."`) are clear and appropriate.

**No functional code changes.** Only documentation comments are modified. N=
o risk of runtime behavior change since this is a UAPI header and only comm=
ent lines are touched.

**Verdict:** Patch is correct and ready to merge. The warnings are real, th=
e fixes are appropriate, and the Tegra maintainer has already acked it.

---
Generated by Claude Code Patch Reviewer