From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amd/display: dmub_cmd.h: correct typos and spellos Date: Tue, 28 Apr 2026 13:53:32 +1000 Message-ID: In-Reply-To: <20260427214122.784024-1-rdunlap@infradead.org> References: <20260427214122.784024-1-rdunlap@infradead.org> <20260427214122.784024-1-rdunlap@infradead.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Status: Good to merge.** This patch fixes 20+ spelling errors identified by codespell and a handful = found manually. All corrections are straightforward and obviously correct: - `alighment` =E2=86=92 `alignment` (1x) - `sequeunce` =E2=86=92 `sequence` (1x) - `optimzations` =E2=86=92 `optimizations` (3x) - `isntance` =E2=86=92 `instance` (16x) - `re-use` =E2=86=92 `reuse` (1x) - `dicated` =E2=86=92 `dictated` (7x) - `afftet` =E2=86=92 `after` (1x) The `afftet` =E2=86=92 `after` fix deserves a note. The resulting comment r= eads: ```c /* * Use FSFT after pixel clk */ uint32_t pix_clk_100hz; ``` This is grammatically terse but plausible in context =E2=80=94 the adjacent= field `sink_pix_clk_100hz` has the comment "Use Original pixel clock", so = "after" likely means "after FSFT adjustment". The original `afftet` was cle= arly garbled, and `after` is the best reasonable interpretation. Randy's open questions about pre-existing comment/field mismatches are well= -spotted: - **(a)** `dark_pos_gain` with comment "Dark negative gain" =E2=80=94 "pos"= and "negative" contradict each other. - **(b)/(c)** `min_frame_rate` has comment "Maximum frame rate" and `max_fr= ame_rate` has "Minimum frame rate" =E2=80=94 the comments are clearly swapp= ed. These are real bugs in the existing documentation but are correctly left ou= t of this patch, as they require AMD domain knowledge to resolve which name= (field vs comment) is correct. A follow-up fix from the AMD display team w= ould be appropriate. One very minor nit: the double period at the end of this comment was not fi= xed: ```c * 16-bit value dictated by driver that indicates the vtotal in PSR active = requirement when screen idle.. ``` The trailing `..` should probably be a single `.`, but that's pre-existing = and doesn't affect the correctness of this patch. --- Generated by Claude Code Patch Reviewer