From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: rust: driver core: drop drvdata before devres release Date: Tue, 28 Apr 2026 13:47:56 +1000 Message-ID: In-Reply-To: <20260427221155.2144848-2-dakr@kernel.org> References: <20260427221155.2144848-1-dakr@kernel.org> <20260427221155.2144848-2-dakr@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Sound and well-motivated. The reordering of `post_unbind_rust` before `devres_release_all` in `device_unbind_cleanup()` is the key C-side enabler. The commit message clearly explains why: with drvdata dropped first, driver structs can hold references to devres-managed resources since those resources are guaranteed to still be alive during the driver struct's destructor. The comment update in `driver.h` is accurate. No issues. --- Generated by Claude Code Patch Reviewer