From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amd/display: Remove duplicate include of dce/dmub_hw_lock_mgr.h Date: Tue, 28 Apr 2026 13:39:57 +1000 Message-ID: In-Reply-To: <20260428030238.1012922-1-nichen@iscas.ac.cn> References: <20260428030238.1012922-1-nichen@iscas.ac.cn> <20260428030238.1012922-1-nichen@iscas.ac.cn> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Status: Correct** The file `dcn42_hwseq.c` included `"dce/dmub_hw_lock_mgr.h"` twice: - Line 29 (retained): `#include "dce/dmub_hw_lock_mgr.h"` =E2=80=94 used by= `dmub_hw_lock_mgr_does_context_require_lock()` and `dmub_hw_lock_mgr_inbox= 0_cmd()` calls later in the file. - Line ~38 (removed by this patch): a second, redundant `#include "dce/dmub= _hw_lock_mgr.h"`. The patch removes only the second occurrence, keeping the first. The remain= ing include is necessary since the file references `dmub_hw_lock_mgr_does_c= ontext_require_lock` and `dmub_hw_lock_mgr_inbox0_cmd` (lines 1032, 1039, 1= 054). No issues. This is a straightforward duplicate include removal. --- Generated by Claude Code Patch Reviewer