From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panthor: Make panthor_irq::state a non-atomic field Date: Tue, 05 May 2026 11:44:52 +1000 Message-ID: In-Reply-To: <20260429-panthor-signal-from-irq-v1-1-4b92ae4142d2@collabora.com> References: <20260429-panthor-signal-from-irq-v1-0-4b92ae4142d2@collabora.com> <20260429-panthor-signal-from-irq-v1-1-4b92ae4142d2@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Verdict: Looks good.** Clean conversion from `atomic_t` to plain `enum panthor_irq_state` now that all accesses are protected by `mask_lock`. The added `scoped_guard()` in `_irq_suspend()` for the `PANTHOR_IRQ_STATE_SUSPENDED` write is correct -- that was the one unprotected access site. The change from `atomic_cmpxchg` to simple compare-and-assign under the spinlock is equivalent in correctness since the lock provides mutual exclusion. --- --- Generated by Claude Code Patch Reviewer