From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings:bridge: Add Lontiun LT7911EXC eDP to MIPI DSI bridge Date: Tue, 05 May 2026 11:58:22 +1000 Message-ID: In-Reply-To: <20260429040541.3404116-2-syyang@lontium.com> References: <20260429040541.3404116-1-syyang@lontium.com> <20260429040541.3404116-2-syyang@lontium.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Port descriptions are swapped.** The binding declares: ```yaml port@0: description: Video port for MIPI DSI output. port@1: description: Video port for eDP input. ``` But the example has: ```yaml port@0: bridge_in: endpoint { remote-endpoint =3D <&edp_out>; }; port@1: bridge_out: endpoint { remote-endpoint =3D <&panel_in>; }; ``` The endpoint label `bridge_in` connecting to `edp_out` at port@0 indicates = port@0 is the eDP **input**, and `bridge_out` connecting to `panel_in` at p= ort@1 indicates port@1 is the MIPI DSI **output**. The driver confirms this= =E2=80=94 it calls `devm_drm_of_get_bridge(dev, dev->of_node, 1, 0)` on po= rt@1 to get the downstream (output) bridge. The descriptions for port@0 and= port@1 should be swapped. **Missing `description` at the top level** of the schema (under `title:`). = While not strictly required, it is conventional. **Typo in the series subject**: "Lontiun" should be "Lontium" (appears in s= ubject line and cover letter). --- --- Generated by Claude Code Patch Reviewer